Skip to content

Add queue system name to run_dialog #10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Apr 24, 2025

Issue
Resolves #10255

Approach
This commit makes the GUI show what queue_system is being used, in the footer of the RunDialog.

(Screenshot of new behavior in GUI if applicable)
Before:
image

After:
image

Screen.Recording.2025-04-24.at.09.21.13.mov
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq added the release-notes:improvement Automatically categorise as improvement in release notes label Apr 24, 2025
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #10679 will not alter performance

Comparing jonathan-eq:improve-gui (a5a09fd) with main (4f22072)

Summary

✅ 25 untouched benchmarks

@berland
Copy link
Contributor

berland commented Apr 25, 2025

Probably "lsf" should be upper-cased when displayed to users.

@jonathan-eq
Copy link
Contributor Author

Probably "lsf" should be upper-cased when displayed to users.

I think it would be good to probably uppercase all queue system names 🤔

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@berland
Copy link
Contributor

berland commented Apr 25, 2025

Probably "lsf" should be upper-cased when displayed to users.

I think it would be good to probably uppercase all queue system names 🤔

Suggest "LSF", "OpenPBS" or "PBS", "Slurm" and "Local"

@jonathan-eq
Copy link
Contributor Author

Probably "lsf" should be upper-cased when displayed to users.

I think it would be good to probably uppercase all queue system names 🤔

Suggest "LSF", "OpenPBS" or "PBS", "Slurm" and "Local"

I am not sure about OpenPBS/PBS. Isn't it still called TORQUE in our config? The users might be confused if they specify the TORQUE queue, and suddenly see PBS queue.

@berland
Copy link
Contributor

berland commented Apr 28, 2025

I am not sure about OpenPBS/PBS. Isn't it still called TORQUE in our config? The users might be confused if they specify the TORQUE queue, and suddenly see PBS queue.

Very good point. We should maybe write "Torque/OpenPBS"

@jonathan-eq
Copy link
Contributor Author

I am not sure about OpenPBS/PBS. Isn't it still called TORQUE in our config? The users might be confused if they specify the TORQUE queue, and suddenly see PBS queue.

Very good point. We should maybe write "Torque/OpenPBS"

Yes, best of both.

This commit makes the GUI show what queue_system is being used, in the footer of the RunDialog.
@jonathan-eq jonathan-eq merged commit 75d2f8f into equinor:main Apr 29, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: show what queue system is ert running on
3 participants