-
Notifications
You must be signed in to change notification settings - Fork 110
Add queue system name to run_dialog #10679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #10679 will not alter performanceComparing Summary
|
e71c197
to
dbab78a
Compare
Probably "lsf" should be upper-cased when displayed to users. |
I think it would be good to probably uppercase all queue system names 🤔 |
dbab78a
to
f277409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
Suggest "LSF", "OpenPBS" or "PBS", "Slurm" and "Local" |
I am not sure about OpenPBS/PBS. Isn't it still called TORQUE in our config? The users might be confused if they specify the TORQUE queue, and suddenly see PBS queue. |
f277409
to
d70dcad
Compare
Very good point. We should maybe write "Torque/OpenPBS" |
Yes, best of both. |
This commit makes the GUI show what queue_system is being used, in the footer of the RunDialog.
d70dcad
to
a5a09fd
Compare
Issue
Resolves #10255
Approach
This commit makes the GUI show what queue_system is being used, in the footer of the RunDialog.
(Screenshot of new behavior in GUI if applicable)

Before:
After:

Screen.Recording.2025-04-24.at.09.21.13.mov
git rebase -i main --exec 'just rapid-tests'
)When applicable