cp: split IDefaultComponent from IComponent #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of std component's default impl
sfwn
force-pushed
the
feature/cp-split-IDefaultComponent
branch
from
e127bd1 to
8cbc1d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 37.69% 37.66% -0.03%
==========================================
Files 68 68
Lines 4295 4298 +3
==========================================
Hits 1619 1619
- Misses 2572 2575 +3
Partials 104 104
|
Effet
approved these changes
Dec 17, 2021
|
/approve |
erda-bot
approved these changes
Dec 17, 2021
bugaolengdeyuxiaoer
pushed a commit
to bugaolengdeyuxiaoer/erda-infra
that referenced
this pull request
Dec 22, 2021
…t of std component's default impl (erda-project#142) Co-authored-by: Effet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind refactor
What this PR does / why we need it:
cp: split IDefaultComponent from IComponent to clarify the development of std component's default impl.
Specified Reivewers:
/assign @Effet @shuofan