Skip to content

Refactor/add check build status cli #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

McDaddy
Copy link
Contributor

@McDaddy McDaddy commented Sep 15, 2021

What this PR does / why we need it:

remove comparison-build script, because we can consolidate all build status in the pre-install step
So that I create check-build-status script to implement the same logic in pre-install step then we can take advantage of if condition function of pipeline. By this pipeline feature, we can skip build directly, no need to ask for build resource and queue

image

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@McDaddy McDaddy added cli erda-ui cli refactor Refactor labels Sep 15, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Sep 16, 2021

Nice

@daskyrk
Copy link
Contributor

daskyrk commented Sep 16, 2021

Conflict

@McDaddy McDaddy force-pushed the feature/add-check-build-status-cli branch from cf285e2 to c98fcbc Compare September 16, 2021 09:40
@McDaddy
Copy link
Contributor Author

McDaddy commented Sep 16, 2021

Conflict

resolved

@daskyrk
Copy link
Contributor

daskyrk commented Sep 17, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Sep 17, 2021
@erda-bot erda-bot merged commit 2c441ba into erda-project:master Sep 17, 2021
@McDaddy McDaddy deleted the feature/add-check-build-status-cli branch October 8, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot cli erda-ui cli refactor Refactor
Development

Successfully merging this pull request may close these issues.

3 participants