Skip to content

feat(cmp): clusters list add new background img #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hujiahao-hjh
Copy link
Contributor

What this PR does / why we need it:

Clusters list add new background images.

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image
image
image

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@hujiahao-hjh hujiahao-hjh added the feature new feature label Nov 25, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Nov 25, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Nov 25, 2021
@erda-bot erda-bot merged commit 2b4ea29 into erda-project:master Nov 25, 2021
laojun pushed a commit to laojun/erda-ui that referenced this pull request Dec 3, 2021
* feat(cmp): clusters list add new background img

* feat: code optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot feature new feature
Development

Successfully merging this pull request may close these issues.

3 participants