Skip to content

fix(common): config page container style bug #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hujiahao-hjh
Copy link
Contributor

What this PR does / why we need it:

Fix config page container style bug of two scroll bars appear on the page or jump to the top of the page when updated.

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

✅ Yes(version is required)
release/1.5-alpha2

Which issue(s) this PR fixes:

Fixes # https://erda-org.erda.cloud/erda/dop/projects/387/issues/all?id=258272&issueFilter__urlQuery=eyJzdGF0ZXMiOls0NDAyLDcxMDQsNzEwNSw0NDAzLDQ0MDQsNzEwNiw0NDA2LDQ0MDcsNDQxMiw0NTM4LDQ0MTMsNDQxNCw0NDE1LDQ0MTZdLCJhc3NpZ25lZUlEcyI6WyIxMDAxMjE0IiwiMjQiXX0%3D&issueTable__urlQuery=eyJwYWdlTm8iOjQsICJwYWdlU2l6ZSI6MTB9&issueViewGroup__urlQuery=eyJ2YWx1ZSI6ImthbmJhbiIsImNoaWxkcmVuVmFsdWUiOnsia2FuYmFuIjoiZGVhZGxpbmUifX0%3D&iterationID=680&type=BUG

@hujiahao-hjh hujiahao-hjh added the bugfix Used in pr label Nov 30, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Nov 30, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Nov 30, 2021
@erda-bot erda-bot merged commit 3c1e9a0 into erda-project:master Nov 30, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Nov 30, 2021

/cherry-pick release/1.5-alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants