Skip to content

Hotfix/circular import #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Hotfix/circular import #2243

merged 2 commits into from
Dec 9, 2021

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Dec 9, 2021

What this PR does / why we need it:

break circular import:

common/utils -> _crud_module  -> agent -> errorHandler -> userStore
 -> layoutStore -> org-home/store -> announceMentStore -> common/utils getDefaultPaging

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@daskyrk daskyrk added the bugfix Used in pr label Dec 9, 2021
@laojun
Copy link
Contributor

laojun commented Dec 9, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Dec 9, 2021
@erda-bot erda-bot merged commit 178c616 into master Dec 9, 2021
@daskyrk daskyrk deleted the hotfix/circular-import branch December 13, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants