Skip to content

fix(dop): issue route bug #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2021

Conversation

hujiahao-hjh
Copy link
Contributor

What this PR does / why we need it:

Issue route bug.

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

✅ Yes(version is required)
hotfix/12-21

Which issue(s) this PR fixes:

Fixes # https://erda-org.erda.cloud/erda/dop/projects/387/issues/all?id=268044&issueFilter__urlQuery=eyJzdGF0ZXMiOls0NDAyLDcxMDQsNzEwNSw0NDAzLDQ0MDQsNzEwNiw0NDA2LDQ0MDcsNDQxMiw0NTM4LDQ0MTMsNDQxNCw0NDE1LDQ0MTZdfQ%3D%3D&issueTable__urlQuery=eyJwYWdlTm8iOjEsICJwYWdlU2l6ZSI6MTB9&iterationID=680&type=BUG

@hujiahao-hjh hujiahao-hjh added the bugfix Used in pr label Dec 22, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Dec 24, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Dec 24, 2021
@erda-bot erda-bot merged commit c6e1527 into erda-project:master Dec 24, 2021
@hujiahao-hjh
Copy link
Contributor Author

/cherry-pick release/1.5

erda-bot pushed a commit to erda-bot/erda-ui that referenced this pull request Dec 27, 2021
* fix(dop): issue route bug

* fix: goto route change
laojun pushed a commit that referenced this pull request Dec 27, 2021
* fix(dop): issue route bug

* fix: goto route change

Co-authored-by: hujiahao-hjh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants