Skip to content

ci: optimize Dockerfile multi-stage build #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

iutx
Copy link
Member

@iutx iutx commented Sep 12, 2024

What this PR does / why we need it:

  1. Optimize Dockerfile multi-stage build.
  2. All build behavior within container.

Local build command:

docker build --build-context erda-ui-enterprise=../erda-ui-enterprise . -t <> 

@laojun @sfwn

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Which issue(s) this PR fixes:

Fixes #

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
❎ No

ChangeLog

Language Changelog
🇺🇸 English optimize Dockerfile multi-stage build
🇨🇳 中文 优化 Dockerfile 多阶段构建

Need cherry-pick to release versions?

✅ Yes(version is required)
❎ No

@iutx iutx requested review from sfwn and laojun September 13, 2024 01:35
@sfwn
Copy link
Member

sfwn commented Sep 13, 2024

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Sep 13, 2024
@erda-bot erda-bot merged commit 124d1c1 into erda-project:master Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot
Development

Successfully merging this pull request may close these issues.

3 participants