Skip to content

support to generate example for application/x-www-form-urlencoded #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2021
Merged

support to generate example for application/x-www-form-urlencoded #1632

merged 3 commits into from
Sep 1, 2021

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Sep 1, 2021

…coded

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

  • supprot to generate example for application/x-www-form-urlencoded
  • do not validate the value of the filed format in OAS3, because it is an open value

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1632 (b5f2ef1) into master (75ac22c) will increase coverage by 0.04%.
The diff coverage is 40.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
+ Coverage   12.98%   13.03%   +0.04%     
==========================================
  Files        1042     1042              
  Lines      108746   108776      +30     
==========================================
+ Hits        14121    14174      +53     
+ Misses      93347    93335      -12     
+ Partials     1278     1267      -11     
Impacted Files Coverage Δ
pkg/swagger/oas3/validate.go 0.00% <0.00%> (ø)
pkg/swagger/oas3/gen_example.go 44.30% <45.45%> (+44.30%) ⬆️
pkg/parser/pipelineyml/visitor_ref_op.go 46.23% <0.00%> (-0.54%) ⬇️
modules/core-services/services/project/project.go 7.59% <0.00%> (+0.76%) ⬆️
...ules/scheduler/executor/plugins/k8s/statefulset.go 52.28% <0.00%> (+5.24%) ⬆️

@johnlanni johnlanni changed the title supprot to generate example for application/x-www-form-urlencoded support to generate example for application/x-www-form-urlencoded Sep 1, 2021
@johnlanni
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit 8aa190e into erda-project:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants