Skip to content

hepa refactor #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Conversation

johnlanni
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind refactor

What this PR does / why we need it:

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@johnlanni johnlanni added hepa ingress management refactor labels Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1744 (8d279cc) into master (56fcf95) will increase coverage by 0.74%.
The diff coverage is 1.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1744      +/-   ##
==========================================
+ Coverage   13.72%   14.46%   +0.74%     
==========================================
  Files        1127     1119       -8     
  Lines      117125   112270    -4855     
==========================================
+ Hits        16071    16241     +170     
+ Misses      99375    94299    -5076     
- Partials     1679     1730      +51     
Impacted Files Coverage Δ
modules/hepa/common/util/misc.go 60.86% <0.00%> (-16.91%) ⬇️
modules/hepa/gateway/dto/api_info_dto.go 0.00% <0.00%> (ø)
modules/hepa/gateway/dto/api_req_dto.go 0.00% <0.00%> (ø)
modules/hepa/gateway/dto/consumer_acls_dto.go 0.00% <0.00%> (ø)
modules/hepa/gateway/dto/consumer_dto.go 0.00% <0.00%> (ø)
modules/hepa/gateway/dto/consumer_info_dto.go 0.00% <0.00%> (ø)
modules/hepa/gateway/dto/manage_domain_info.go 0.00% <ø> (ø)
modules/hepa/gateway/dto/open_limit_rule_dto.go 0.00% <0.00%> (ø)
modules/hepa/gateway/dto/openapi_info_dto.go 0.00% <0.00%> (ø)
modules/hepa/gateway/dto/openapi_req_dto.go 0.00% <0.00%> (ø)
... and 50 more

@johnlanni johnlanni requested a review from sfwn September 8, 2021 13:19
@sfwn
Copy link
Member

sfwn commented Sep 8, 2021

/approve

@erda-bot erda-bot merged commit f418689 into erda-project:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants