Skip to content

cherry-pick/optimize node list #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CraigMChen
Copy link
Contributor

What type of this PR

Add one of the following kinds:

/kind polish

What this PR does / why we need it:

  1. optimize nodes list
  2. fix events list sort

Specified Reviewers:

/assign @johnlanni

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

@erda-bot erda-bot requested a review from johnlanni October 13, 2021 03:38
@CraigMChen CraigMChen changed the title Cherry pick/node requests optimize node requests Oct 13, 2021
@CraigMChen CraigMChen changed the title optimize node requests cherry-pick/optimize node list Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #2355 (06121b9) into release/1.3 (3135bcc) will decrease coverage by 0.01%.
The diff coverage is 21.65%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.3    #2355      +/-   ##
===============================================
- Coverage        16.09%   16.08%   -0.02%     
===============================================
  Files             1178     1178              
  Lines           116222   116325     +103     
===============================================
+ Hits             18704    18706       +2     
- Misses           95621    95699      +78     
- Partials          1897     1920      +23     
Impacted Files Coverage Δ
...mponents/cmp-dashboard-nodes/common/table/table.go 14.90% <0.00%> (ø)
.../cmp-dashboard-workload-detail/podsTable/render.go 22.86% <0.00%> (+0.08%) ⬆️
modules/cmp/steve/aggregator.go 0.00% <0.00%> (ø)
modules/cmp/steve/response.go 0.00% <0.00%> (ø)
modules/cmp/component-protocol/cputil/util.go 26.77% <3.33%> (-12.57%) ⬇️
.../components/cmp-dashboard-nodes/cpuTable/render.go 13.87% <10.00%> (+0.26%) ⬆️
modules/cmp/steve/proxy/cache_store.go 47.72% <71.42%> (ø)
...ponents/cmp-dashboard-events-list/filter/render.go 15.57% <83.33%> (ø)
...nts/cmp-dashboard-events-list/eventTable/render.go 53.81% <84.21%> (-0.60%) ⬇️
... and 4 more

@johnlanni johnlanni merged commit 03ce4ef into erda-project:release/1.3 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants