-
Notifications
You must be signed in to change notification settings - Fork 379
refactor: manual test case&plan-case-relations paging use sql join #2910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
863e7d4
to
09e9622
Compare
Codecov Report
@@ Coverage Diff @@
## master #2910 +/- ##
==========================================
- Coverage 17.56% 17.47% -0.10%
==========================================
Files 1325 1325
Lines 135161 135824 +663
==========================================
- Hits 23747 23739 -8
- Misses 108960 109629 +669
- Partials 2454 2456 +2
|
fc14e9e
to
3b2ef19
Compare
3b2ef19
to
2a1be81
Compare
2a1be81
to
50b0468
Compare
Effet
approved these changes
Nov 10, 2021
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Nov 10, 2021
…rda-project#2910) * refacotr: manual test case&plan-case-relations paging use sql join * limit testset's directory length * fix: manual-test fix paging by updatedAt * migration: manual test add migration for slow sql * add unit test for mt-case-paging refactor
erda-bot
added a commit
that referenced
this pull request
Nov 10, 2021
…2910) (#2985) * refacotr: manual test case&plan-case-relations paging use sql join * limit testset's directory length * fix: manual-test fix paging by updatedAt * migration: manual test add migration for slow sql * add unit test for mt-case-paging refactor Co-authored-by: sfwn <[email protected]>
snakorse
pushed a commit
to snakorse/erda
that referenced
this pull request
Nov 10, 2021
…rda-project#2910) * refacotr: manual test case&plan-case-relations paging use sql join * limit testset's directory length * fix: manual-test fix paging by updatedAt * migration: manual test add migration for slow sql * add unit test for mt-case-paging refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind refactor
What this PR does / why we need it:
fix slow sql:
Tested in dev and feels good :P
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @Effet
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.4
when this PR is merged.