Skip to content

action add timeout input #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Nov 22, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

The action graphical interface adds a timeout input field

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English The action graphical interface adds a timeout input field
🇨🇳 中文 action 图形化界面增加 timeout 输入字段

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #3125 (0407257) into master (0d67328) will increase coverage by 0.00%.
The diff coverage is 58.82%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3125   +/-   ##
=======================================
  Coverage   17.37%   17.38%           
=======================================
  Files        1361     1361           
  Lines      140423   140479   +56     
=======================================
+ Hits        24398    24416   +18     
- Misses     113488   113515   +27     
- Partials     2537     2548   +11     
Impacted Files Coverage Δ
...l/scenarios/action/components/actionForm/render.go 3.37% <58.82%> (+3.37%) ⬆️
modules/actionagent/define.go 9.52% <0.00%> (-6.27%) ⬇️
modules/actionagent/callback.go 20.56% <0.00%> (-1.41%) ⬇️
cmd/actionagent/main.go 0.00% <0.00%> (ø)
modules/actionagent/exit.go 0.00% <0.00%> (ø)
modules/actionagent/execute.go 0.00% <0.00%> (ø)
modules/actionagent/prestop.go 100.00% <0.00%> (ø)
modules/actionagent/step_logic.go 0.00% <0.00%> (ø)
modules/actionagent/step_prepare.go 0.00% <0.00%> (ø)
... and 3 more

@kakj-go kakj-go force-pushed the feature/action-add-timeout-input branch from f01c20a to 0407257 Compare November 22, 2021 08:22
@sfwn
Copy link
Member

sfwn commented Nov 23, 2021

/approve

@erda-bot erda-bot merged commit a250c17 into erda-project:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants