Skip to content

edit autotest plan reload table but not reset pageNum #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Nov 23, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

When the user edits the name of the plan, the paging data of the table will be reloaded. This behavior does not conform to the user's operating habits

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English After the automated test pagination is edited, the pagination will no longer change
🇨🇳 中文 自动化测试分页编辑后,分页不再变化

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #3137 (6b9cdf7) into master (9d6ae0b) will increase coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3137      +/-   ##
==========================================
+ Coverage   17.40%   17.45%   +0.05%     
==========================================
  Files        1361     1369       +8     
  Lines      140473   140799     +326     
==========================================
+ Hits        24454    24582     +128     
- Misses     113494   113673     +179     
- Partials     2525     2544      +19     
Impacted Files Coverage Δ
...ios/auto-test-plan-list/components/table/render.go 53.93% <80.00%> (+7.97%) ⬆️
modules/cmp/steve/server.go 0.00% <0.00%> (ø)
...es/services/dingtalk/api/manager/client_factory.go 100.00% <0.00%> (ø)
.../services/dingtalk/api/manager/userinfo_manager.go 69.69% <0.00%> (ø)
...-services/services/dingtalk/api/manager/manager.go 100.00% <0.00%> (ø)
...rvices/dingtalk/api/manager/accesstoken_manager.go 62.50% <0.00%> (ø)
modules/cmp/steve/schemas.go 0.00% <0.00%> (ø)
modules/cmp/steve/dynamiccolumns.go 0.00% <0.00%> (ø)
...ices/services/dingtalk/api/manager/task_context.go 93.33% <0.00%> (ø)
...re-services/services/dingtalk/api/native/native.go 80.00% <0.00%> (ø)
... and 1 more

@kakj-go kakj-go force-pushed the feature/autotest-plan-not-reset-page branch from beebc0b to d3795dd Compare November 23, 2021 06:55
@kakj-go kakj-go requested a review from sfwn November 23, 2021 07:03
@kakj-go kakj-go force-pushed the feature/autotest-plan-not-reset-page branch from d3795dd to 6b9cdf7 Compare November 23, 2021 07:06
@sfwn
Copy link
Member

sfwn commented Nov 23, 2021

/approve

@erda-bot erda-bot merged commit 72ae83c into erda-project:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants