Skip to content

feature: update relation between trending and waterfall chart of test dashboard #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

littlejiancc
Copy link
Contributor

@littlejiancc littlejiancc commented Dec 1, 2021

What type of this PR

feature: update relation between trending and waterfall
Add one of the following kinds:
/kind feature

What this PR does / why we need it:

feature: update relation between trending and waterfall

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn December 1, 2021 12:38
@littlejiancc littlejiancc force-pushed the feature/test-dashboard-waterfall branch from 3a09476 to bf24908 Compare December 2, 2021 02:19
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #3233 (2651f93) into master (f225174) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3233      +/-   ##
==========================================
- Coverage   17.64%   17.62%   -0.03%     
==========================================
  Files        1372     1372              
  Lines      141880   142004     +124     
==========================================
- Hits        25032    25024       -8     
- Misses     114239   114371     +132     
  Partials     2609     2609              
Impacted Files Coverage Δ
modules/cmp/metrics/metricsReq.go 12.69% <0.00%> (-49.53%) ⬇️
...e/pipengine/reconciler/queuemanage/manager/stop.go 62.50% <0.00%> (-37.50%) ⬇️
modules/cmp/metrics/metrics.go 19.06% <0.00%> (-5.03%) ⬇️
...rotocol/components/cmp-cluster-list/list/render.go 30.09% <0.00%> (-0.31%) ⬇️
modules/cmp/metricsImpl.go 0.00% <0.00%> (ø)
apistructs/pipeline_queue.go 80.70% <0.00%> (ø)
...dules/core/monitor/alert/alert-apis/adapt/alert.go 16.87% <0.00%> (+0.31%) ⬆️
pkg/mock/mock.go 45.45% <0.00%> (+5.05%) ⬆️

@littlejiancc littlejiancc force-pushed the feature/test-dashboard-waterfall branch 2 times, most recently from 28830a1 to 3f98bd9 Compare December 2, 2021 04:02
@littlejiancc littlejiancc added the dop devops plaoform label Dec 2, 2021
@littlejiancc littlejiancc force-pushed the feature/test-dashboard-waterfall branch 2 times, most recently from 1477543 to 57cf0b5 Compare December 2, 2021 05:29
@littlejiancc littlejiancc changed the title feature: update relation between trending and waterfall of test dashboard feature: update relation between trending and waterfall chart of test dashboard Dec 2, 2021
@littlejiancc littlejiancc force-pushed the feature/test-dashboard-waterfall branch from 57cf0b5 to 2651f93 Compare December 2, 2021 05:58
@sfwn
Copy link
Member

sfwn commented Dec 2, 2021

/approve

@erda-bot erda-bot merged commit 76521f7 into erda-project:master Dec 2, 2021
@littlejiancc littlejiancc deleted the feature/test-dashboard-waterfall branch December 6, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants