Skip to content

pipeline loop task clean result #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chengjoey
Copy link
Member

What type of this PR

Add one of the following kinds:
/kind bugfix

What this PR does / why we need it:

pipeline loop task clean result

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that clean pipeline loop task
🇨🇳 中文 修复了loop task 没有清空result

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added bug pipeline pipeline service labels Dec 3, 2021
@chengjoey chengjoey force-pushed the fix/pipeline-reset-result-nil branch from 07dcff2 to 9255cc6 Compare December 3, 2021 11:52
@chengjoey chengjoey force-pushed the fix/pipeline-reset-result-nil branch from 9255cc6 to c94d84a Compare December 5, 2021 12:11
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #3270 (c94d84a) into master (583d6eb) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3270      +/-   ##
==========================================
- Coverage   17.67%   17.67%   -0.01%     
==========================================
  Files        1371     1372       +1     
  Lines      141984   142053      +69     
==========================================
+ Hits        25092    25104      +12     
- Misses     114226   114331     +105     
+ Partials     2666     2618      -48     
Impacted Files Coverage Δ
...es/pipeline/pipengine/reconciler/taskrun/update.go 2.85% <50.00%> (+2.85%) ⬆️
...pipeline/pipengine/reconciler/taskrun/task_loop.go 80.88% <100.00%> (ø)
...omponents/cmp-dashboard-nodes/nodeFilter/render.go 48.00% <0.00%> (-1.34%) ⬇️
pkg/parser/pipelineyml/visitor_ref_op.go 46.23% <0.00%> (-0.54%) ⬇️
modules/dop/services/issue/issue.go 3.04% <0.00%> (-0.16%) ⬇️
apistructs/issue_related.go 0.00% <0.00%> (ø)
modules/dop/endpoints/issue_related.go 0.00% <0.00%> (ø)
apistructs/issue_state.go 0.00% <0.00%> (ø)
apistructs/issue.go 9.00% <0.00%> (+0.04%) ⬆️
...s/services/notify/channel/notify.chanel.service.go 67.97% <0.00%> (+3.93%) ⬆️

@sfwn
Copy link
Member

sfwn commented Dec 8, 2021

Does these looped results stored in pipeline reports?

@chengjoey
Copy link
Member Author

Does these looped results stored in pipeline reports?

image
stored,becase report task loop before reset task

@sfwn
Copy link
Member

sfwn commented Dec 8, 2021

/approve

@erda-bot erda-bot merged commit d821138 into erda-project:master Dec 8, 2021
@chengjoey chengjoey deleted the fix/pipeline-reset-result-nil branch April 18, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants