Skip to content

add terminus_define_tag lable for spark job #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chengjoey
Copy link
Member

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

support spark job logs

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Support spark job logs
🇨🇳 中文 实现spark 任务日志查看

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added feature pipeline pipeline service labels Dec 6, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #3275 (0a6e80d) into master (1f750f1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3275      +/-   ##
==========================================
+ Coverage   17.67%   17.68%   +0.01%     
==========================================
  Files        1372     1372              
  Lines      142049   142070      +21     
==========================================
+ Hits        25102    25123      +21     
  Misses     114330   114330              
  Partials     2617     2617              
Impacted Files Coverage Δ
modules/pipeline/pkg/containers/task_container.go 96.72% <100.00%> (+1.72%) ⬆️

@chengjoey chengjoey force-pushed the feature/pipeline-sparkapp-logs branch from 21eec28 to 7394d15 Compare December 6, 2021 06:59
@chengjoey
Copy link
Member Author

chengjoey commented Dec 6, 2021

spark driver terminus define tag:
image

@chengjoey chengjoey force-pushed the feature/pipeline-sparkapp-logs branch from 7394d15 to 0a6e80d Compare December 6, 2021 08:29
@chengjoey
Copy link
Member Author

image

@sfwn
Copy link
Member

sfwn commented Dec 8, 2021

/approve

@erda-bot erda-bot merged commit 9ecd897 into erda-project:master Dec 8, 2021
@chengjoey chengjoey deleted the feature/pipeline-sparkapp-logs branch April 18, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants