Skip to content

fix: quota audit #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2021
Merged

fix: quota audit #3349

merged 3 commits into from
Dec 14, 2021

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Dec 13, 2021

What type of this PR

Add one of the following kinds:
/kind bugfix

What this PR does / why we need it:

Fix the problem that the audit information is incorrect when the quota is 0 before the upgrade and the quota is modified after the upgrade

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@dspo dspo requested review from luobily and CraigMChen December 13, 2021 06:16
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #3349 (528d91b) into master (33ef224) will decrease coverage by 0.05%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3349      +/-   ##
==========================================
- Coverage   17.85%   17.80%   -0.06%     
==========================================
  Files        1377     1384       +7     
  Lines      142888   143708     +820     
==========================================
+ Hits        25511    25582      +71     
- Misses     114700   115423     +723     
- Partials     2677     2703      +26     
Impacted Files Coverage Δ
modules/core-services/services/project/project.go 16.06% <40.00%> (+0.20%) ⬆️
...ashboard-workload-detail/operationButton/render.go 37.83% <0.00%> (-16.64%) ⬇️
pkg/database/sqlparser/snapshot/snapshot.go 14.81% <0.00%> (-8.89%) ⬇️
...p-dashboard-workloads-list/workloadTable/render.go 49.01% <0.00%> (-8.55%) ⬇️
...tocol/components/issue-manage/issueTable/render.go 35.81% <0.00%> (-6.16%) ⬇️
...rotocol/components/cmp-cluster-list/list/render.go 30.55% <0.00%> (-2.46%) ⬇️
...e/monitor/metric/storage/elasticsearch/provider.go 18.26% <0.00%> (-1.74%) ⬇️
.../components/cmp-dashboard-pods/podsTable/render.go 14.84% <0.00%> (-1.29%) ⬇️
modules/monitor/apm/topology/topology.go 27.58% <0.00%> (-1.22%) ⬇️
...odules/core/monitor/log/query/log.query.service.go 17.43% <0.00%> (-0.72%) ⬇️
... and 16 more

@luobily
Copy link
Member

luobily commented Dec 14, 2021

/approve

@erda-bot erda-bot merged commit a1d545f into erda-project:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants