Skip to content

jump over empty addon #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

chengjoey
Copy link
Member

What type of this PR

Add one of the following kinds:
/kind bugfix

What this PR does / why we need it:

jump over nil addon field

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that jump over empty addon
🇨🇳 中文 修复了orchestrator遇到空的addon配置panic的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added bug orchestrator workload management labels Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #3351 (b3ab12d) into master (076a72a) will increase coverage by 0.08%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3351      +/-   ##
==========================================
+ Coverage   17.79%   17.88%   +0.08%     
==========================================
  Files        1384     1386       +2     
  Lines      143698   144398     +700     
==========================================
+ Hits        25578    25822     +244     
- Misses     115434   115870     +436     
- Partials     2686     2706      +20     
Impacted Files Coverage Δ
...estrator/services/deployment/deployment_context.go 12.01% <66.66%> (+2.75%) ⬆️
...e/monitor/metric/storage/elasticsearch/provider.go 14.42% <0.00%> (-3.85%) ⬇️
...odules/core/monitor/log/query/log.query.service.go 16.93% <0.00%> (-0.51%) ⬇️
modules/cmp/impl/clusters/import_cluster.go 22.30% <0.00%> (-0.24%) ⬇️
modules/core/monitor/log/query/routes.go 11.68% <0.00%> (-0.16%) ⬇️
modules/monitor/apm/topology/topology.go 27.54% <0.00%> (-0.05%) ⬇️
apistructs/pipeline.go 0.00% <0.00%> (ø)
modules/core-services/endpoints/notify_group.go 0.00% <0.00%> (ø)
...r/plugins/scheduler/executor/plugins/k8sjob/msg.go 0.00% <0.00%> (ø)
...lugins/scheduler/executor/plugins/k8sjob/k8sjob.go 24.86% <0.00%> (ø)
... and 8 more

@chengjoey chengjoey force-pushed the fix/orchestrator-deploy-panic branch 3 times, most recently from ea8a5eb to 9f37bc6 Compare December 14, 2021 08:26
@@ -24,6 +24,8 @@ import (
"github.com/pkg/errors"
"github.com/stretchr/testify/assert"

"github.com/erda-project/erda/modules/orchestrator/services/addon"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted

@chengjoey chengjoey force-pushed the fix/orchestrator-deploy-panic branch from 9f37bc6 to b3ab12d Compare December 14, 2021 12:08
@Effet Effet merged commit 80aaf2d into erda-project:master Dec 17, 2021
@chengjoey chengjoey deleted the fix/orchestrator-deploy-panic branch April 18, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug orchestrator workload management
Development

Successfully merging this pull request may close these issues.

2 participants