Skip to content

refactor: service group resource subscribe ratio #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Feb 13, 2025

Conversation

iutx
Copy link
Member

@iutx iutx commented Jan 9, 2025

What this PR does / why we need it:

  1. fix mysql resource config error

  2. optimize resources getter
    Global SubscribeRatio

  3. If the SubscribeRatio isn't configured in the non-production workspace, we'll go with the global settings.
    Otherwise, we'll stick to the workspace-specific configuration.

  4. Also affects in the production workspace.

  5. Init container not set resource limit

  6. Sidecar container set similar subscribe ration rule

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn @luobily

ChangeLog

Language Changelog
🇺🇸 English fix mysql resource config error
🇨🇳 中文 修复 mysql 资源配置错误

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot
Copy link
Member

erda-bot commented Jan 9, 2025

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6479/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:34894: i/o timeout

@iutx iutx marked this pull request as draft January 9, 2025 12:05
@iutx iutx requested review from sfwn and luobily January 10, 2025 05:33
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 30.90783% with 997 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (eeb85d7) to head (6d43739).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...er/executor/plugins/k8s/servicegroup_operations.go 0.00% 366 Missing ⚠️
...strator/scheduler/executor/plugins/k8s/podscale.go 23.05% 337 Missing ⚠️
...chestrator/scheduler/executor/plugins/k8s/utils.go 25.64% 56 Missing and 2 partials ⚠️
...rator/scheduler/executor/plugins/k8s/deployment.go 25.45% 37 Missing and 4 partials ⚠️
...r/executor/plugins/k8s/addon/redis/legacy/redis.go 0.00% 27 Missing ⚠️
...ator/scheduler/executor/plugins/k8s/check_quota.go 0.00% 25 Missing ⚠️
...er/executor/plugins/k8s/addon/rocketmq/rocketmq.go 5.26% 18 Missing ⚠️
...ator/scheduler/executor/plugins/k8s/statefulset.go 28.00% 18 Missing ⚠️
...r/plugins/k8s/addon/elasticsearch/elasticsearch.go 0.00% 17 Missing ⚠️
...ugins/k8s/oversubscriberatio/oversubscriberatio.go 89.80% 12 Missing and 4 partials ⚠️
... and 12 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6479    +/-   ##
========================================
  Coverage   15.12%   15.12%            
========================================
  Files        3675     3682     +7     
  Lines      377054   376950   -104     
========================================
- Hits        57040    57031     -9     
+ Misses     314561   314467    -94     
+ Partials     5453     5452     -1     
Flag Coverage Δ
by-github-actions 15.12% <30.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...strator/scheduler/executor/plugins/k8s/affinity.go 100.00% <100.00%> (ø)
...orchestrator/scheduler/executor/plugins/k8s/k8s.go 25.38% <100.00%> (-0.22%) ⬇️
...cheduler/executor/plugins/k8s/addon/redis/unify.go 0.00% <0.00%> (ø)
...cheduler/executor/plugins/k8s/addon/mysql/mysql.go 55.12% <80.00%> (-6.07%) ⬇️
...chestrator/scheduler/executor/plugins/k8s/istio.go 76.92% <76.92%> (ø)
...orchestrator/scheduler/executor/plugins/k8s/job.go 47.90% <57.14%> (+2.71%) ⬆️
...strator/scheduler/executor/plugins/k8s/registry.go 85.18% <85.18%> (ø)
...tools/orchestrator/scheduler/executor/util/util.go 37.59% <50.00%> (+0.37%) ⬆️
...cheduler/executor/plugins/k8s/addon/canal/canal.go 31.14% <73.91%> (-1.17%) ⬇️
...or/scheduler/executor/plugins/k8s/addon/process.go 0.00% <0.00%> (ø)
... and 14 more

... and 4 files with indirect coverage changes

@iutx iutx marked this pull request as ready for review January 15, 2025 10:06
@erda-bot
Copy link
Member

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6479/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:34895: i/o timeout

@iutx iutx changed the title fix: mysql resource config error refactor: service group resource subscribe ration Jan 20, 2025
@iutx iutx added orchestrator workload management refactor labels Jan 20, 2025
@erda-bot
Copy link
Member

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6479/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:34895: i/o timeout

@iutx iutx self-assigned this Jan 20, 2025
@iutx iutx requested a review from CeerDecy January 22, 2025 09:21
Copy link

stale bot commented Feb 12, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 12, 2025
@CeerDecy CeerDecy removed the wontfix label Feb 13, 2025
@iutx iutx force-pushed the fix/mysql-resource-config-error branch from 7a61d41 to 6f626be Compare February 13, 2025 06:53
@iutx iutx changed the title refactor: service group resource subscribe ration refactor: service group resource subscribe ratio Feb 13, 2025
@erda-bot
Copy link
Member

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6479/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:35999: i/o timeout

@iutx iutx requested a review from sfwn February 13, 2025 09:14
@sfwn
Copy link
Member

sfwn commented Feb 13, 2025

/approve

@sfwn sfwn merged commit 732140e into erda-project:master Feb 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants