Skip to content

Add support for firefox android #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelEbert
Copy link

add min_version 68.9.
This will allow it to be installed on android from the store. Additionally, 68.9 is 4 years old, so this shouldn't block anyone from installing it on older browser versions.

add min_version 68.9.
This will allow it to be installed on android from the store. 
Additionally, 68.9 is 4 years old, so this shouldn't block anyone from installing it on older browser versions.
Copy link
Owner

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply here. It looks like the extension did what it was set to do 😅

Accept these changes and I'll be sure to update the Firefox extension, fellow Firefox user.

@@ -1,9 +1,9 @@
{
"manifest_version": 2,

"name": "Millennials to Snake People",
"name": "Snake People to Snake People",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Snake People to Snake People",
"name": "Millennials to Snake People",

"short_name": "Snake People",
"description": "Replaces the text 'Millennial' with 'Snake People'.",
"description": "Replaces the text 'Snake Person' with 'Snake People'.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Replaces the text 'Snake Person' with 'Snake People'.",
"description": "Replaces the text 'Millennials' with 'Snake People'.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants