Skip to content

erts: Fix crash when invoking non-existent error_handler #9696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jhogberg
Copy link
Contributor

@jhogberg jhogberg commented Apr 7, 2025

No description provided.

@jhogberg jhogberg added team:VM Assigned to OTP team VM fix labels Apr 7, 2025
@jhogberg jhogberg requested a review from bjorng April 7, 2025 11:02
@jhogberg jhogberg self-assigned this Apr 7, 2025
Copy link
Contributor

github-actions bot commented Apr 7, 2025

CT Test Results

  1 files   11 suites   2m 15s ⏱️
 91 tests  87 ✅ 4 💤 0 ❌
106 runs  102 ✅ 4 💤 0 ❌

Results for commit b1de378.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

bjorng
bjorng previously approved these changes Apr 8, 2025
@@ -772,6 +772,34 @@ test_apply_errors() ->
[{M,whatever,[42],_}|_] = Stk2
end,

%% ERIERL-1220: Set a bad error handler on purpose, this used to crash the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This testcase seems to fail when running the interpreter.

@jhogberg jhogberg force-pushed the john/erts/fix-call_error_handler-crash/OTP-19577/ERIERL-1220 branch from f37069f to 8815c05 Compare April 14, 2025 07:19
@jhogberg jhogberg requested a review from bjorng April 24, 2025 16:33
bjorng
bjorng previously approved these changes Apr 28, 2025
@jhogberg jhogberg force-pushed the john/erts/fix-call_error_handler-crash/OTP-19577/ERIERL-1220 branch from e9d4b70 to b1de378 Compare April 28, 2025 17:10
@u3s u3s merged commit aa9e6a2 into erlang:maint-25 May 8, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants