-
Notifications
You must be signed in to change notification settings - Fork 35
e2e test cases for the reconcile loop #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
e2e test cases for the reconcile loop #51
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abdurrehman107 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @abdurrehman107. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…rehman/e2e-test-cases-etcd-cluster' of github.com:abdurrehman107/etcd-operator into abdur-rehman/e2e-test-cases-etcd-cluster
@ahrtr Can we please review the tests I've pushed? I tried adding the Health Check tests too by referring to the Health Check function referred in the Reconcile loop, but it did not work out. I'd appreciate help at that end. |
It's hard to review such a huge PR. Please only focus on the first step as mentioned in #19 (comment). |
@ahrtr there exist valid e2e tests in this PR, do we want to take those up in another PR? I'll close this one and raise those in another PR? |
either reusing this PR or raising a new PR works for me, it's up to you. thx |
This PR refers to the issue #19. We've used the e2e-framework deliver tests.