Skip to content

e2e test cases for the reconcile loop #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

abdurrehman107
Copy link
Member

This PR refers to the issue #19. We've used the e2e-framework deliver tests.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abdurrehman107
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @abdurrehman107. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abdurrehman107 abdurrehman107 changed the title e2e test cases for the operator e2e test cases for the reconcile loop Jan 24, 2025
abdurrehman107 and others added 3 commits January 24, 2025 16:50
…rehman/e2e-test-cases-etcd-cluster' of github.com:abdurrehman107/etcd-operator into abdur-rehman/e2e-test-cases-etcd-cluster
@abdurrehman107 abdurrehman107 marked this pull request as ready for review February 2, 2025 13:41
@abdurrehman107
Copy link
Member Author

@ahrtr Can we please review the tests I've pushed? I tried adding the Health Check tests too by referring to the Health Check function referred in the Reconcile loop, but it did not work out. I'd appreciate help at that end.

@ahrtr
Copy link
Member

ahrtr commented Feb 3, 2025

It's hard to review such a huge PR. Please only focus on the first step as mentioned in #19 (comment).

@abdurrehman107
Copy link
Member Author

abdurrehman107 commented Mar 10, 2025

@ahrtr there exist valid e2e tests in this PR, do we want to take those up in another PR? I'll close this one and raise those in another PR?

@ahrtr
Copy link
Member

ahrtr commented Mar 12, 2025

@ahrtr there exist valid e2e tests in this PR, do we want to take those up in another PR? I'll close this one and raise those in another PR?

either reusing this PR or raising a new PR works for me, it's up to you. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants