Skip to content

Revert "Add new value for EIP-1559 elasticity for WorldChain Sepolia and Mainnet" #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

sebastianst
Copy link
Member

@sebastianst sebastianst commented Apr 9, 2025

Reverts #922

The elasticity parameters in the chain config must not be changed when they are dynamically changed later. These values must reflect the static config that was present pre-Holocene.

In a follow up, we'll move the [optimism] section into the [genesis] section to avoid this footgun (#969).

For context, Worldchain mainnet was updated with this tx

@sebastianst sebastianst requested a review from a team as a code owner April 9, 2025 18:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.64%. Comparing base (fb90035) to head (fc9f321).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   43.64%   43.64%           
=======================================
  Files          39       39           
  Lines        2305     2305           
=======================================
  Hits         1006     1006           
  Misses       1210     1210           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebastianst sebastianst added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit 84838da Apr 9, 2025
10 checks passed
@sebastianst sebastianst deleted the revert-922-wc-eip1559-update branch April 9, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants