Skip to content

Update EIP-712: typo, reference ERC spec correctly and formats #9872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

normanzb
Copy link

@normanzb normanzb commented Jun 8, 2025

Originally just to update a tiny typo (a above to above) in existing EIP-712, then the bot gave a bunch of errors relating to format... so here is it

@normanzb normanzb requested a review from eth-bot as a code owner June 8, 2025 16:46
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-interface labels Jun 8, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 8, 2025

File EIPS/eip-712.md

Requires 1 more reviewers from @dekz, @LogvinovLeon, @recmo
Requires 1 more reviewers from @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jun 8, 2025
@normanzb normanzb force-pushed the fix/typo-eip-712 branch from b59c9f3 to e89da14 Compare June 8, 2025 16:54
@normanzb normanzb changed the title Update EIP-712: typo Update EIP-712: typo and reference ERC spec correctly Jun 8, 2025
@normanzb normanzb changed the title Update EIP-712: typo and reference ERC spec correctly Update EIP-712: typo, reference ERC spec correctly and formats Jun 8, 2025
@normanzb normanzb force-pushed the fix/typo-eip-712 branch 3 times, most recently from 4089b12 to 5a31a2a Compare June 8, 2025 17:05
@normanzb normanzb force-pushed the fix/typo-eip-712 branch from 5a31a2a to f9f49a2 Compare June 8, 2025 17:07
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, you @normanzb will need to reach out to authors for them to signal/approve nothing materially has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants