core/vm: add a failed flag to detect tx execution status #14637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is used to indicate whether state revert happen during state transition. if child's revert flag been set, it will also affect its parent recursively
detect whether tx is reverted during state transition and save to receipt if so.
rjl493456442
force-pushed
the
master
branch
3 times, most recently
from
37734c1 to
f19d90f
Compare
rjl493456442
changed the title
reverted in receipt
rjl493456442
force-pushed
the
master
branch
2 times, most recently
from
cb7d283 to
af0c5ef
Compare
Motivation:
Current problem with gas estimation is not all cases is correct
using gas metrics, e.g. in the frontier contract deploys can fail without
consuming all gas due to have not enough gas to store contract code.
So a `failed` flag is useful which can detect the vm execution
status.
In Addition:
the `Reverted` flag has been removed, since it is too sensitive to
insert addtional field to it.
|
This is a really useful improvement - but wouldn't it be a lot more useful if it bubbled up the actual error, rather than just a boolean indicating an error occurred? |
holiman
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this PR:
Now the gas is estimated through the gas is consumed all. But this method does not apply to all scenes. e.g. in the frontier contract deploys can fail without consuming all gas due to have not enough gas to store contract code.
So a
failedflag returned by vm is useful to detect whether an error occurred during the execution of the transaction. It can help to estimate gas accurately.