Skip to content

core/type: change receipt status code #18194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

needkane
Copy link
Contributor

Code History : bool -> uint-> uint64

In PR(#15042) description, we know a question

there are multiple failures [Out of gas] or [Bad jump destination] how does statutscode express

so solution is use ‘’uint ‘’ replace ‘’bool ‘’ for multiple failures .

But, irrational status code compared with linux exit code.
As everyone knows , linux command exit code , 0 represent success, other codes reprsent multiple failures

@holiman
Copy link
Contributor

holiman commented Nov 28, 2018

While I understand the intent, we can't unilaterally change this in geth, without changing all other clients and all libraries that depend on the current behaviour.

@holiman holiman closed this Nov 28, 2018
@karalabe
Copy link
Member

I.e. these codes are part of consensus https://eips.ethereum.org/EIPS/eip-658

@needkane needkane deleted the pp007 branch December 13, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants