p2p/discover: expose discv5 functions for portal JSON-RPC interface #31117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Kai <[email protected]>
fjl
reviewed
Mar 11, 2025
p2p/discover/v5_udp.go
Outdated
| // LocalNode returns the current local node running the | ||
| // RoutingTableInfo returns the routing table information. Used for Portal discv5 RoutingTableInfo API. | ||
| func (t *UDPv5) RoutingTableInfo() [][]string { | ||
| return t.tab.nodeIds() |
There was a problem hiding this comment.
We should expose Table.Nodes method instead because it has more information.
fjl
reviewed
Mar 11, 2025
p2p/discover/v5_udp.go
Outdated
| return t.tab.nodeIds() | ||
| } | ||
|
|
||
| // AddKnownNode adds a node to the routing table. Used for Portal discv5 AddEnr API. |
There was a problem hiding this comment.
This should have a comment that says it's only for testing.
fjl
reviewed
Mar 11, 2025
p2p/discover/v5_udp.go
Outdated
|
|
||
| // WaitInit waits for the routing table to be initialized. | ||
| func (t *UDPv5) WaitInit() { | ||
| t.tab.waitInit() |
There was a problem hiding this comment.
Better to add a config option (in discover/common.go) that disables init check in table.
There was a problem hiding this comment.
this change will be made in another PR.
fjl
reviewed
Mar 11, 2025
p2p/discover/v5_udp.go
Outdated
| } | ||
|
|
||
| // PingWithResp calls PING on a node and waits for a PONG response. | ||
| func (t *UDPv5) PingWithResp(n *enode.Node) (*v5wire.Pong, error) { |
There was a problem hiding this comment.
We can just change Ping signature to return the response object. No need to add WithoutResp method.
Signed-off-by: Chen Kai <[email protected]>
Signed-off-by: Chen Kai <[email protected]>
Signed-off-by: Chen Kai <[email protected]>
fjl
changed the title
fjl
approved these changes
Mar 13, 2025
sivaratrisrinivas
pushed a commit
to sivaratrisrinivas/go-ethereum
that referenced
this pull request
Apr 21, 2025
…thereum#31117) Fixes ethereum#31093 Here we add some API functions on the UDPv5 object for the purpose of implementing the Portal Network JSON-RPC API in the shisui client. --------- Signed-off-by: Chen Kai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #31093 .
Function Renaming for Clarity:
discv5_pingjson rpc endpoint, added aPingWithRespfunction and renamedPingtoPingWithoutRespfor refactoring.discv5_routingTableInfojson rpc endpoint, addedRoutingTableInfofunction andnodeIdsfunction.discv5_deleteEnrjson rpc endpoint, addedDeleteNodefunction anddeleteNodefunction.discv5_lookupEnrjson rpc endpoint, addedResolveNodeIdfunction.discv5_addEnrjson rpc endpoint, addedAddKnownNodefunction.discv5_GetEnrjson rpc endpoint, renamedgetNodetoGetNode.discv5_findNodejson rpc endpoint, renamedfindnodetoFindnode.WaitInitfunction andwaitInitfor support portal hive test.AllNodesfunction.This is the discv5 api impl code