crypto/kzg4844: add ComputeCells functionality #31378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
gballet,
jwasinger,
holiman and
fjl
as code owners
MariusVanDerWijden
force-pushed
the
ckzg-update
branch
from
405c706 to
1911a9f
Compare
|
Problem rn is that gokzg startup is much slower now: crate-crypto/go-eth-kzg#110 |
|
Please run |
|
TODO: rebase and rerun ci |
MariusVanDerWijden
force-pushed
the
ckzg-update
branch
from
f5f0abc to
78b1453
Compare
fjl
approved these changes
Apr 29, 2025
Closed
0g-wh
pushed a commit
to 0g-wh/0g-geth
that referenced
this pull request
May 8, 2025
For PeerDAS, we need to compute cell proofs. Both ckzg and gokzg support computing these cell proofs. This PR does the following: - Update the go-kzg library from "github.com/crate-crypto/go-kzg-4844" to "github.com/crate-crypto/go-eth-kzg" which will be the new upstream for go-kzg moving forward - Update ckzg from v1.0.0 to v2.0.1 and switch to /v2 - Updates the trusted setup to contain the g1 points both in lagrange and monomial form - Expose `ComputeCells` to compute the cell proofs
fjl
pushed a commit
that referenced
this pull request
May 13, 2025
I saw in #31378 introduced github.com/crate-crypto/go-eth-kzg to calculate the kzg hash, and github.com/crate-crypto/go-kzg-4844 was only used in the test files, so propose to drop it with go-eth-kzg instead
Dargon789
pushed a commit
to Dargon789/go-ethereum
that referenced
this pull request
May 27, 2025
…eum#31806) I saw in ethereum#31378 introduced github.com/crate-crypto/go-eth-kzg to calculate the kzg hash, and github.com/crate-crypto/go-kzg-4844 was only used in the test files, so propose to drop it with go-eth-kzg instead
2dvorak
added a commit
to 2dvorak/kaia
that referenced
this pull request
Jun 17, 2025
In accordance with ethereum/go-ethereum#31378 and ethereum/go-ethereum#31806.
da1suk8
pushed a commit
to da1suk8/kaia
that referenced
this pull request
Jun 26, 2025
In accordance with ethereum/go-ethereum#31378 and ethereum/go-ethereum#31806.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PeerDAS, we need to compute cell proofs. Both ckzg and gokzg support computing these cell proofs.
This PR does the following:
ComputeCellsto compute the cell proofs