core/vm: implement EIP 7883 - ModExp Gas Cost Increase #31606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
changed the title
fjl
reviewed
Jun 4, 2025
fjl
reviewed
Jun 4, 2025
|
Please rebase. |
MariusVanDerWijden
force-pushed
the
eip-7883
branch
from
f3ba0f7 to
7b6cbde
Compare
fjl
reviewed
Jun 5, 2025
| @@ -440,6 +453,14 @@ func (c *bigModExp) RequiredGas(input []byte) uint64 { | |||
| gas.Rsh(gas, 3) | |||
| gas.Mul(gas, gas) | |||
|
|
|||
| var minPrice uint64 = 200 | |||
| if c.eip7883 { | |||
There was a problem hiding this comment.
Since this check is within the if c.eip2565 block, the two EIPs are effectively dependent on each other and cannot be toggled separately. Not sure if we need to be able to have them fully separate, but maybe it would be more appropriate to toggle them with a single setting.
fjl
approved these changes
Jun 5, 2025
Thegaram
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Jun 23, 2025
https://eips.ethereum.org/EIPS/eip-7883 --------- Co-authored-by: MariusVanDerWijden <[email protected]> Co-authored-by: Felix Lange <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-7883