eth/catalyst: allow duplicate blob hashes #31788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguenther
requested review from
MariusVanDerWijden,
lightclient,
fjl and
jwasinger
as code owners
MariusVanDerWijden
approved these changes
May 9, 2025
MariusVanDerWijden
merged commit 8c22059
into
ethereum:peerdas-devnet-6
1 of 2 checks passed
MariusVanDerWijden
pushed a commit
that referenced
this pull request
May 9, 2025
While running kurtosis and spamoor, I noticed occasional `null` entries coming back from `getBlobsV2`. After investigating, I found that spamoor can use the same blob data across multiple transactions, so with larger blob counts, there's an increased chance that a blob is included in a block more than once. As a result, previous indexes in the hash-to-index map in `getBlobsV2` would get overwritten. I changed the map from `map[common.Hash]int` to `map[common.Hash][]int` to handle this case. I decided to go this route because it's the smallest-possible fix, but it could also make sense to update `blobpool.GetBlobs` to de-duplicate the hashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running kurtosis and spamoor, I noticed occasional
nullentries coming back fromgetBlobsV2. After investigating, I found that spamoor can use the same blob data across multiple transactions, so with larger blob counts, there's an increased chance that a blob is included in a block more than once. As a result, previous indexes in the hash-to-index map ingetBlobsV2would get overwritten.I changed the map from
map[common.Hash]inttomap[common.Hash][]intto handle this case. I decided to go this route because it's the smallest-possible fix, but it could also make sense to updateblobpool.GetBlobsto de-duplicate the hashes.