Skip to content

evm: consistent error message names #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Apr 25, 2025

This PR:

  • Makes the EVMErrorMessage singular (EVMErrorMessages -> EVMErrorMessage)
  • Renames EOFError to EOFErrorMessage to be consistnet with the above.

The convention would then be:

  • Error messages live under an enum-like const/type that is named XYZErrorMessage
  • Error classes or wrappers are named XYZError (e.g. EVMError)
  • These error classes may have a message property that is then typed as XYZErrorMessage

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 55.62130% with 75 lines in your changes missing coverage. Please review.

Project coverage is 79.55%. Comparing base (47529d0) to head (4f7f26d).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.99% <ø> (ø)
common 97.51% <ø> (ø)
devp2p 86.71% <ø> (-0.08%) ⬇️
evm 73.11% <55.62%> (-0.02%) ⬇️
mpt 89.74% <ø> (ø)
statemanager 69.06% <ø> (ø)
static 99.11% <ø> (ø)
tx 90.59% <ø> (ø)
util 89.36% <ø> (ø)
vm 55.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit f10cb80 into master Apr 25, 2025
39 of 40 checks passed
@holgerd77 holgerd77 deleted the evm/error-message-renaming branch April 25, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants