fix(cli): --watch normalisation with=true #4132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
Apr 12, 2025
| @@ -300,7 +300,7 @@ func main() { | |||
| for _, arg := range osArgs { | |||
| if !strings.HasPrefix(arg, "-") { | |||
| nonFlagCount++ | |||
| } else if arg == "--serve" || arg == "--watch" || strings.HasPrefix(arg, "--serve=") { | |||
| } else if arg == "--watch" || strings.HasPrefix(arg, "--watch=") || arg == "--serve" || strings.HasPrefix(arg, "--serve=") { | |||
There was a problem hiding this comment.
This seems inaccurate for =false options (it already was for serve, now also for watch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns it with how the internal CLI parser accepts
--watch=truewhich was implemented in ce04765.Before
--watch=truewas not correctly identified as "Watch Mode" and disabled the GC as a drive by. This caused memory leaks.Resolves #4131