Skip to content

fix #4133: Update go 1.23.7 => 1.23.8 #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v3
with:
go-version: 1.23.7
go-version: 1.23.8
id: go

- name: Setup Node.js environment
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v3
with:
go-version: 1.23.7
go-version: 1.23.8
id: go

- name: Setup Node.js environment
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v3
with:
go-version: 1.23.7
go-version: 1.23.8
id: go

- name: Setup Node.js environment
Expand Down Expand Up @@ -274,7 +274,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v3
with:
go-version: 1.23.7
go-version: 1.23.8
id: go

# Make sure esbuild works with old versions of Deno. Note: It's important
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v3
with:
go-version: 1.23.7
go-version: 1.23.8
id: go

- name: Validation checks
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

* Update Go from 1.23.7 to 1.23.8 ([#4133](https://github.com/evanw/esbuild/issues/4133), [#4134](https://github.com/evanw/esbuild/pull/4134))

This should have no effect on existing code as this version change does not change Go's operating system support. It may remove certain reports from vulnerability scanners that detect which version of the Go compiler esbuild uses. Fixed vulnerability CVE-2025-22871.

## 0.25.2

* Support flags in regular expressions for the API ([#4121](https://github.com/evanw/esbuild/issues/4121))
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test-all:
@$(MAKE) --no-print-directory -j6 test-common test-deno ts-type-tests test-wasm-node test-wasm-browser lib-typecheck test-yarnpnp

check-go-version:
@go version | grep ' go1\.23\.7 ' || (echo 'Please install Go version 1.23.7' && false)
@go version | grep ' go1\.23\.8 ' || (echo 'Please install Go version 1.23.8' && false)

# Note: Don't add "-race" here by default. The Go race detector is currently
# only supported on the following configurations:
Expand Down