Skip to content

Moves compileQueryParser to separate module #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wesleytodd
Copy link
Member

Moved this functionality to a separate module so I could use it in my other package. It appears no tests were originally written, so I added some in the module. If you would like we can move this repo under pillar, or here, just let me know.

https://github.com/wesleytodd/compile-query-parser

@dougwilson
Copy link
Contributor

Probably should hard-pin the qs version within that module to meet the typical version range policy (pin exact versions, but if the module is part of Express, it may float patches with ~).

@wesleytodd wesleytodd force-pushed the compile-query-parser branch from ca849e1 to e8e2c4c Compare March 27, 2017 01:02
@wesleytodd
Copy link
Member Author

I updated that in the module, and assuming it will move into the express family somewhere I used the tilde in here.

@wesleytodd
Copy link
Member Author

Anything blocking us from moving forward? Do we need to move the repo or can it live where it is?

@wesleytodd
Copy link
Member Author

This change is neither breaking nor required to ship v5. This was done so that it could be used individually in another project I was working on at the time, but is otherwise not necessary. I am going to remove the v5 label and we can decide if it is worth doing later as a minor.

@UlisesGascon UlisesGascon changed the base branch from 5.0 to master March 23, 2025 20:45
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside of the conflict... this require a change in the HISTORY.md, but I am +1 for this idea.

@bjohansebas
Copy link
Member

Sure, is that package going to be moved to this organization? by organization, I mean one of the three that exist.

@UlisesGascon UlisesGascon mentioned this pull request Mar 23, 2025
68 tasks
@UlisesGascon UlisesGascon added 6.x semver-major This change is a semver major labels Mar 26, 2025
@wesleytodd
Copy link
Member Author

The original goal of this PR was primarily to allow alternate frameworks and libraries who may need it to use the official express style query parsing. I did this because we were using it in the browser at the time. Since then we as a project have decided that browser support is not currently on our priority list for express and many of the project's other libraries. With that in mind, I am going to close this. We can always re-open it latter or replace it with a new one if we change our minds.

@wesleytodd wesleytodd closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.x ideas pr semver-major This change is a semver major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants