feat: enhance --mounts: display mount root path #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
changed the title
vlad20012
force-pushed
the
mount-root
branch
2 times, most recently
from
2ade1e8 to
2702e78
Compare
cafkafk
requested changes
May 1, 2025
There was a problem hiding this comment.
Thanks, this is pretty cool. One thing I do think would be nice before merge is if the mounts would be aligned on the grid (and respect the --header flag as well). Currently, the mounts are unaligned.
E.g. see:
$ eza -l / --mounts --header --no-permissions --no-user --no-filesize --no-time
Name
bin
boot [/dev/nvme0n1p1 (vfat)]
dev [devtmpfs (devtmpfs)]
etc
home [zpool/home (zfs)]
lib
lib64
mnt
nix [zpool/nix (zfs)]
opt
proc [proc (proc)]
root
run [tmpfs (tmpfs)]
rustup
srv
sys [sysfs (sysfs)]
tmp [tmpfs (tmpfs)]
usr
var [zpool/var (zfs)]
The path of root is printed in square brackets next to a mount source, similar to `findmnt` command output. The root is not displayed if it equals to `/`. Example: ``` mkdir /foo && mkdir /bar; mount --bind /bar /foo eza -l --mounts / # /bar # /foo [/dev/sda1[/bar] (ext4)] # ... findmnt /foo # /foo /dev/sda1[/bar] ext4 rw,relatime,errors=remount-ro ``` This is useful for `mount --bind` as well as for mounts of non-default btrfs subvolumes.
|
@cafkafk Oh wait, after some thought, it began to seem to me that mount are rather similar to symlik destinations. And symlinks destinations seems not aligned in both
So, do you really think mounts should be aligned regardless? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path of mount root is now printed in square brackets next to a mount source, similar
to
findmntcommand output. The root is not displayed if it equals to/.Example:
This is useful for
mount --bindas well as for mounts of non-default btrfs subvolumes.Linux only.