Skip to content

no_proxy ipv6 entries not handled correctly #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shawkins opened this issue Jan 10, 2025 · 7 comments · Fixed by #6782
Closed

no_proxy ipv6 entries not handled correctly #6781

shawkins opened this issue Jan 10, 2025 · 7 comments · Fixed by #6782
Assignees
@shawkins
Milestone
7.1.0

Comments

@shawkins
Copy link
Contributor

Describe the bug

ipv6 entries that appear in the no_proxy list are not checked.

Fabric8 Kubernetes Client version

6.11.0

Steps to reproduce

set NO_PROXY to contain an ipv6 entry 2048::/110

Expected behavior

Addresses within the range should not use a proxy

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3@latest

Environment

Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

No response
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jan 10, 2025
@shawkins
fix: allowing no_proxy to use ipv6 values
124f6d4 
closes: fabric8io#6781

Signed-off-by: Steve Hawkins <[email protected]>
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jan 10, 2025
@shawkins
fix: allowing no_proxy to use ipv6 values
fea4bc6 
closes: fabric8io#6781

Signed-off-by: Steve Hawkins <[email protected]>
This was referenced Jan 10, 2025
Merged
Closed
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jan 10, 2025
@shawkins
fix: allowing no_proxy to use ipv6 values
9d27e52 
closes: fabric8io#6781

Signed-off-by: Steve Hawkins <[email protected]>
@manusa manusa added this to the 7.1.0 milestone Jan 13, 2025 — with automated-tasks
manusa pushed a commit that referenced this issue Jan 13, 2025
@shawkins
fix: allowing no_proxy to use ipv6 values
2939fbe 
closes: #6781

Signed-off-by: Steve Hawkins <[email protected]>
@shawkins
Copy link
Contributor Author

@manusa I think we will need this for our next release of Keycloak, so we'll probably need this in Quarkus 3.15.x.

cc @metacosm @vmuzikar

@manusa
Copy link
Member

manusa commented Jan 23, 2025

Should we backport the fix to 6.13 then?

(I'm assuming this based on https://github.com/quarkusio/quarkus/blob/7c367ac49c2f617b6e348247d5b219e91a993f34/pom.xml#L72)

@shawkins
Copy link
Contributor Author

Should we backport the fix to 6.13 then?

Yes, I believe that is still the target release.

@vmuzikar
Copy link

We need it in Quarkus 3.20, as IPv6 isn't coming until Keycloak 26.2.

@manusa
Copy link
Member

manusa commented Jan 24, 2025 •
edited
Loading

So no back-port + release needed then?

If that's the case, I can prioritize releasing 7.1 (which was the original plan for next week).

Also, @shawkins, I'd need your input for #6792, to see if we need to do something there or leave it as is.

@vmuzikar
Copy link

So no back-port + release needed then?

I'm not sure which version Quarkus 3.20, especially JOSDK will use. CC @metacosm

@metacosm
Copy link
Collaborator

So no back-port + release needed then?

I'm not sure which version Quarkus 3.20, especially JOSDK will use. CC @metacosm

QOSDK 7 will be used in Quarkus 3.20 (Fabric8 client 7 is used in Quarkus starting with 3.18). QOSDK 7 will use JOSDK 5 which has breaking API changes (though they shouldn't be too difficult to adapt for).

manusa pushed a commit to manusa/kubernetes-client that referenced this issue Jan 28, 2025
@shawkins @manusa
fix: allowing no_proxy to use ipv6 values
ca6fa81 
closes: fabric8io#6781

Signed-off-by: Steve Hawkins <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
This was referenced Jan 28, 2025
Merged
Merged
@wayneguow wayneguow mentioned this issue Feb 13, 2025
Closed
dongjoon-hyun pushed a commit to apache/spark that referenced this issue Feb 13, 2025
@wayneguow @dongjoon-hyun
[SPARK-51195][BUILD][K8S] Upgrade kubernetes-client to 7.1.0
ae2d2e8 
### What changes were proposed in this pull request?

This PR aims to upgrade `kubernetes-client` from 7.0.1 to 7.1.0.

### Why are the changes needed?

Keep the dependencies to the latest, and there are some bug fixes in version 7.1.0:
- Fix fabric8io/kubernetes-client#6725: (crd-generator) CRD generator missing type for GenericKubernetesResource
- Fix fabric8io/kubernetes-client#6747: Preventing websocket error logs when the client is closed
- Fix fabric8io/kubernetes-client#6781: Allowing ipv6 entries to work in NO_PROXY
- Fix fabric8io/kubernetes-client#6792: VertxHttpClient uses exclusive Vert.x instance by default

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49925 from wayneguow/kubernetes-client.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun pushed a commit to apache/spark that referenced this issue Feb 14, 2025
@wayneguow @dongjoon-hyun
[SPARK-51195][BUILD][K8S] Upgrade kubernetes-client to 7.1.0
dcb3b44 
### What changes were proposed in this pull request?

This PR aims to upgrade `kubernetes-client` from 7.0.1 to 7.1.0.

### Why are the changes needed?

Keep the dependencies to the latest, and there are some bug fixes in version 7.1.0:
- Fix fabric8io/kubernetes-client#6725: (crd-generator) CRD generator missing type for GenericKubernetesResource
- Fix fabric8io/kubernetes-client#6747: Preventing websocket error logs when the client is closed
- Fix fabric8io/kubernetes-client#6781: Allowing ipv6 entries to work in NO_PROXY
- Fix fabric8io/kubernetes-client#6792: VertxHttpClient uses exclusive Vert.x instance by default

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49925 from wayneguow/kubernetes-client.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit ae2d2e8)
Signed-off-by: Dongjoon Hyun <[email protected]>
@vmuzikar vmuzikar mentioned this issue Feb 19, 2025
Open
kazemaksOG pushed a commit to kazemaksOG/spark-custom-scheduler that referenced this issue Mar 27, 2025
@wayneguow @kazemaksOG
[SPARK-51195][BUILD][K8S] Upgrade kubernetes-client to 7.1.0
286fc9d 
### What changes were proposed in this pull request?

This PR aims to upgrade `kubernetes-client` from 7.0.1 to 7.1.0.

### Why are the changes needed?

Keep the dependencies to the latest, and there are some bug fixes in version 7.1.0:
- Fix fabric8io/kubernetes-client#6725: (crd-generator) CRD generator missing type for GenericKubernetesResource
- Fix fabric8io/kubernetes-client#6747: Preventing websocket error logs when the client is closed
- Fix fabric8io/kubernetes-client#6781: Allowing ipv6 entries to work in NO_PROXY
- Fix fabric8io/kubernetes-client#6792: VertxHttpClient uses exclusive Vert.x instance by default

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49925 from wayneguow/kubernetes-client.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
7.1.0
4 participants
@metacosm @manusa @shawkins @vmuzikar