fix #5194: deflaking ScaleIT and addressing timing issue in visitResources #5198
+111
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawkins
requested review from
manusa,
oscerd,
rohanKanojia and
sunix
as code owners
shawkins
changed the title
|
A couple of times I've seen https://github.com/fabric8io/kubernetes-client/actions/runs/5179269358/jobs/9332264916?pr=5206#step:6:450 where the expected group count does not match the actual number visited. I'll update this pr to be more diagnostic for that - it's not clear just from the failure which group is being skipped, or how we should be tolerant to that. |
manusa
reviewed
Jun 14, 2023
Comment on lines
+739
to
+740
| APIGroupList apiGroups = getApiGroups(); | ||
| if (apiGroups != null) { |
There was a problem hiding this comment.
The underlying rest call is allowed to return null on a 404. However that isn't expected here. It could be accounted for with an assertion instead.
manusa
approved these changes
Jun 14, 2023
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5194
Minor change in ScaleIT to ensure the api metadata lookup is ready, also updating visitResources to perform null checks
Type of change
test, version modification, documentation, etc.)
Checklist