fix: HttpLoggingInterceptor uses response body ByteBuffer copy #5250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some HttpClient implementations (OkHttpClientImpl) are sending downstream the originally received ByteBuffer(s). This fix forces the interceptor to store a copy of the ByteBuffer so when the body is logged the buffer is not actually consumed Signed-off-by: Marc Nuri <[email protected]>
manusa
requested review from
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
oscerd
approved these changes
Jun 15, 2023
rohanKanojia
approved these changes
Jun 15, 2023
This was referenced Jun 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
17 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this pull request
Oct 19, 2023
…ptor to not consume response bytes (fabric8io#5251) Add a unit test in AbstractHttpLoggingInterceptor to verify response bytes are not consumed after they've been processed by HttpLoggingInterceptor. I've verified that test fails when I revert fabric8io#5250 in httpclient-okhttp and httpclient-vertx modules Signed-off-by: Rohan Kumar <[email protected]>
11 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this pull request
Oct 19, 2023
…ptor to not consume response bytes (fabric8io#5251) Add a unit test in AbstractHttpLoggingInterceptor to verify response bytes are not consumed after they've been processed by HttpLoggingInterceptor. I've verified that test fails when I revert fabric8io#5250 in httpclient-okhttp and httpclient-vertx modules Signed-off-by: Rohan Kumar <[email protected]>
manusa
pushed a commit
that referenced
this pull request
Nov 9, 2023
…ptor to not consume response bytes (#5251) Add a unit test in AbstractHttpLoggingInterceptor to verify response bytes are not consumed after they've been processed by HttpLoggingInterceptor. I've verified that test fails when I revert #5250 in httpclient-okhttp and httpclient-vertx modules Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some HttpClient implementations (OkHttpClientImpl) are sending downstream the originally received ByteBuffer(s).
This fix forces the interceptor to store a copy of the ByteBuffer so when the body is logged the buffer is not actually consumed
Type of change
test, version modification, documentation, etc.)
Checklist