Skip to content

Add undefined_attributes field to product syncing #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

carterbuce
Copy link
Contributor

Description

The /fb-checkout URL does not work for product variants that use the "Any Size", "Any Color", etc attribute selection. They must define the attribute. This PR sends a list of the attributes that do not have a defined value to Meta, so that we can hide those variants from Shops but still allow them to be synced over for use in Ads.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [] I have commented my code, particularly in hard-to-understand areas.
  • [] I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • [] I followed general Pull Request best practices. Meta employees to follow this wiki.
  • [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

Add undefined_attributes field to product syncing

Test Plan

Synced a product to Meta and verified the undefined_attributes field is sent

Screenshots

Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate

Before

After

@facebook-github-bot
Copy link
Contributor

@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants