Skip to content

montblanc: config: Update configuration of COME 2nd source sensors to FBOSS Sensor Config #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CliffyWong
Copy link
Contributor

Description

This PR is about updating the configuration of Minipack3 COME 2nd source sensors to FBOSS Sensor's configurations

Motivation

The sensor service hw test failed on Minipack3 devices equipped with the 2nd source COME due to an unsuitable configuration in the Montblanc sensor service config file.
In this PR, the configuration for the 2nd source COME sensors will be reverted to the original version, which is correct and functional.

Test Plan

The correctness of the format has been verified on this jsonlint website.
Verified the updated configurations on the Minipack 3 machine configured with 2nd source COME:

  • Run the platform manager/sensor service with the updated config file on the Minipack3 device
  • Run fw_util check unit version information.
  • Run the weutil check the unit eeprom data and product sub version.

Test log as follows:
1.There was a sensor discovery failure on the 2nd source COME device prior to updating the sensor configuration:
image

2.Sensor_service run successfully on the 2nd source COME device after updating the sensor configuration:
image

Minipack3_2nd_COMe_sensor_service_log-BeforeAndAfter.txt
Minipack3_main_COMe_sensor_service_log.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants