Prevent Required and NotRequired qualifiers together in TypedDict fields

[ajaymiranda]

Summary:

This PR resolves #414 by adding a check and testcase to prevent Required and NotRequired from being used together as qualifiers in TypedDict fields.

Changes:

• Implemented a validation check in solve.rs to reject conflicting qualifiers.
• Added a testcase in typed_dict.rs to cover this case.

[ndmitchell]

This looks great! I suggested a minor performance tweak, but definitely a good change.

[ndmitchell]

This code first checks if the required is present (I think using a linear scan), but only uses that result if qualifier == Qualifier::Required. It would be more efficient to inline has_required and has_not_required, then you only do the scan if you are on a relevant qualifier.

[ajaymiranda]

Certainly! Thanks, I’ll update the code.

[yangdanny97]

I'd expect test.py to generate some changes to the conformance outputs - was this not the case?

[ajaymiranda]

I'd expect test.py to generate some changes to the conformance outputs - was this not the case?

Apologies for the oversight. The outputs were generated, but I missed committing them after running test.py. I'll add them, thanks.

[facebook-github-bot]

@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[rchen152]

Review automatically exported from Phabricator review in Meta.

[facebook-github-bot]

@yangdanny97 merged this pull request in 0dc7768.