Registering Push Notifications Twice

[bleonard]

I've been following #2332 and am glad that it looks like it will be in, but I still think there is an issue. I'm running iOS 8+

I'm seeing the push registration callback twice.

My appdelegate looks like this...

- (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings {
  [RCTPushNotificationManager application:application didRegisterUserNotificationSettings:notificationSettings];
}

- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
  [RCTPushNotificationManager application:application didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
}

- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)notification
{
  [RCTPushNotificationManager application:application didReceiveRemoteNotification:notification];
}

The JS code ends up calling requestPermissions (RCTPushNotificationManager.m) which does

[[UIApplication sharedApplication] registerUserNotificationSettings:notificationSettings];
[[UIApplication sharedApplication] registerForRemoteNotifications];

Then there is the appdelgate callback to didRegisterUserNotificationSettings and then didRegisterForRemoteNotificationsWithDeviceToken(both)

The first one calls back into RCTPushNotificationManager, which does this.

+ (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(__unused UIUserNotificationSettings *)notificationSettings
{
  [application registerForRemoteNotifications];
}

You'll note there is a second call to registerForRemoteNotifications

My iOS guy says he would remove the call to registerForRemoteNotifications in requestPermissions

Anyone else seeing this?

[DannyvanderJagt]

I have tried to replicate your problem but the register callback keeps firing once.

Which version of RN are you using?
If you did use v0.12 and lower did you apply the fix from #2332 ?

[bleonard]

I'll try it again in the more recent releases.

[chirag04]

I'm also seeing this on 0.17.

registerPermissions calls

 [app registerUserNotificationSettings:notificationSettings];
 [app registerForRemoteNotifications];

react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.m

Line 160 in b9c5f75

[app registerForRemoteNotifications];

and didRegisterUserNotificationSettings also calls registerForRemoteNotifications

react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.m

Line 78 in b9c5f75

[[UIApplication sharedApplication] registerForRemoteNotifications];

cc @ericvicenti @nicklockwood

[insraq]

I've tried this on RN 0.19 and can reproduce this issue.

[yueshuaijie]

I use 0.19, have this problem, too.

my code:

• (void)application:(UIApplication_)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData_)deviceToken
  {
  [RCTPushNotificationManager didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
  }

[MichaelCereda]

i'm currently on 0.18 and i see this problem too, to avoid too many useless calls to my server i solved (not really) the issue adding a timeout+lock similar to this

   this.lock = false;
   ............
   ...........
   PushNotificationIOS.addEventListener('register', (token)=>{
      if(!this.lock){
        ....... sending token to server here .....
        this.lock = true;
        setTimeout(()=>{this.lock=false},1000*5); // 5 seconds
      }
    });

[insraq]

@MichaelCereda You could just comment out the the call to registerForRemoteNotifications in requestPermission. That's way easier. Just patch RCTPushNotificationManager.m

react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.m

Line 160 in b9c5f75

[app registerForRemoteNotifications];

[MichaelCereda]

thanks @insraq i just used this method because i don't want to patch react-native itself (and lose the changes in case of an update) :)
thank you anyways.

[insraq]

Can we have a PR for this?

[jacob-israel-turner]

I'm having this same issue, a PR would be nice. Is the best solution to simply remove the registerForRemoteNotifications call in requestPermissions?