-
Notifications
You must be signed in to change notification settings - Fork 24.6k
Output of URL.toString doesn't match Node/Chromium #50747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tip Newer version available: You are on a supported minor version, but it looks like there's a newer patch available - 0.79.1. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases. |
Tip Newer version available: You are on a supported minor version, but it looks like there's a newer patch available - undefined. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases. |
still reproducible in v0.79.1 |
Hi @Rexogamer, thanks for the issue. This commit 51ffc5c happened 8 month ago and it is the most recent change to the |
Summary: We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Differential Revision: D73101813
Summary: We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Differential Revision: D73101813
Summary: We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Differential Revision: D73101813
Summary: Pull Request resolved: facebook#50757 We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Differential Revision: D73101813
Summary: Pull Request resolved: #50757 We received [this issue](#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Reviewed By: huntie Differential Revision: D73101813 fbshipit-source-id: 36f1d23b3ad7882c16524843621d9ebbcc09b95d
Summary: Pull Request resolved: facebook#50757 We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Reviewed By: huntie Differential Revision: D73101813 fbshipit-source-id: 36f1d23b3ad7882c16524843621d9ebbcc09b95d
Description
(apologies if this is the wrong repo - is this a Hermes issue?)
the output of
new URL().to string()
doesn't seem to match Node or Chromium, which leads me to believe the bug is with React Native or whoever is implementingURL
.this bug has caused issues for me, as (say)
https://foo.net?bar=baz/
is different fromhttps://foo.net/?bar=baz
(the param isbaz/
, when it should bebaz
).Node:
versus the same functions run with RN:
Steps to reproduce
React Native Version
0.79.1
Affected Platforms
Runtime - Android, Build - Linux
Output of
npx @react-native-community/cli info
Stacktrace or Logs
Reproducer
https://github.com/Rexogamer/react-native-url-bug
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: