Skip to content

Added ability to specify an alternative port for the run-android command #13825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

seantimm
Copy link

@seantimm seantimm commented May 7, 2017

… to allow simultaneous iOS / Android hot reload connections via separate packager instances.

Motivation (required)

When attempting to use Hot Reloading on an iOS and Android device at the same time (with the packager instance), it switches between them as you interact with the devices rather than working with both. To resolve this, each device needs to be pointed to a separate packager instance. The current hardcoding of port 8081 makes this difficult. This pull request introduces a new "--port" option for the run-android command.

Test Plan (required)

I need help here. From what I can tell, my change is sane and is correctly propagating the port to every level. I'm doing an adb reverse from 8081 to the specified port in order to allow the hardcoded 8081 in the native device constants to continue working.

However, I think I have something misconfigured in my environment for building React Native for Android as I am getting a javascript error in my app on master even prior to my change, and it's also looking for the bundle in the wrong location. I don't know if I'm just experiencing a problem introduced on master, or if it's me. 🤷‍♂️

Next Steps

I've signed the CLA, and I'm hoping someone can help review this change or guide me in what I've screwed up in my build environment.

…and to allow simultaneous iOS / Android hot reload connections via separate packagers
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 7, 2017
@skevy
Copy link
Contributor

skevy commented Jun 8, 2017

Hi there!

The packager no longer lives in this repo. It now lives in https://github.com/facebook/metro-bundler. The reasoning for the split is explained here: #13976.

If you're still interested in pursuing changes to the packager for this PR, please open a PR on that repo! :)

Thanks!
-Adam

@hramos hramos closed this Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants