[TM] add spec for HeadlessJsTaskSupport #24907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
| @@ -261,16 +262,22 @@ const AppRegistry = { | |||
| const taskProvider = taskProviders.get(taskKey); | |||
| if (!taskProvider) { | |||
| console.warn(`No task registered for key ${taskKey}`); | |||
| NativeModules.HeadlessJsTaskSupport.notifyTaskFinished(taskId); | |||
| if (NativeHeadlessJsTaskSupport) { | |||
There was a problem hiding this comment.
Flow complains if I don’t. Android only lib. I could attempt to make less of them?
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ericlewis in 56c3852. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: part of facebook#24875 ## Changelog [General] [Added] - add TM spec for HeadlessJsTaskSupport Pull Request resolved: facebook#24907 Reviewed By: RSNara Differential Revision: D15425720 Pulled By: fkgozali fbshipit-source-id: 2e904f265a68066918bae4f6f95494ad77654598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
part of #24875
Changelog
[General] [Added] - add TM spec for HeadlessJsTaskSupport
Test Plan
Flow passes