Implement FormData.set method and handle Blob instances #30767
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The proposed changes brings
FormData
's implementation one step closer to spec compliance by:.set
method.filename
argument on both.set
and.append
forBlob
andFile
values.Blob
instances in.getParts
instead of just blob-like objects with theuri
property.Additionally, I've took the opportunity to improve
FormData
s test suite overall by adding more test cases.It's worth noting that according to the implementation of
URL.createObjectURL
, the call may fail if the native blob module is not available. However, I don't know which circumstances determine its availability:Changelog
[JavaScript] [Added] - Implement
FormData.set
.[JavaScript] [Added] - Add support to
filename
argument on bothFormData.set
andFormData.append
forBlob
andFile
values.Test Plan
Run the following command at the root of React Native's directory: