adjust ats settings in plist in pod install #38086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47041590 |
Base commit: 605db44 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#38086 Changelog: [Internal] in this diff, we update the developer's Info.plists to have the correct ATS settings introducing usage of products: https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project#products-instance_method, in order to retrieve the plists Differential Revision: D47041590 fbshipit-source-id: 4118127e7be5374ff8bb7225ebdf6b00e06f7177
philIip
force-pushed
the
export-D47041590
branch
from
9481ff5 to
fff1d60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47041590 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#38086 Changelog: [Internal] in this diff, we update the developer's Info.plists to have the correct ATS settings introducing usage of products: https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project#products-instance_method, in order to retrieve the plists Differential Revision: D47041590 fbshipit-source-id: b1ffc36478f37ece6006fd5360b058d94d076f41
philIip
force-pushed
the
export-D47041590
branch
from
fff1d60 to
3a4ace8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47041590 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#38086 Changelog: [Internal] in this diff, we update the developer's Info.plists to have the correct ATS settings introducing usage of files: https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project#files-instance_method, in order to retrieve the plists Differential Revision: D47041590 fbshipit-source-id: 03a2d8759c50f58a2364c96f30900a44e47b3328
philIip
force-pushed
the
export-D47041590
branch
from
3a4ace8 to
0452f55
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47041590 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#38086 Changelog: [Internal] in this diff, we update the developer's Info.plists to have the correct ATS settings introducing usage of files: https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project#files-instance_method, in order to retrieve the plists Differential Revision: D47041590 fbshipit-source-id: d2cf908a7b1c34f7f2e3523914a3f5facc503f2d
philIip
force-pushed
the
export-D47041590
branch
from
0452f55 to
1dc8797
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47041590 |
Summary: Pull Request resolved: facebook#38086 Changelog: [Internal] in this diff, we update the developer's Info.plists to have the correct ATS settings introducing usage of files: https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project#files-instance_method, in order to retrieve the plists Reviewed By: cipolleschi Differential Revision: D47041590 fbshipit-source-id: 14a1c182e0e7f0dbc105fc960a115bda0b3b8fd2
philIip
force-pushed
the
export-D47041590
branch
from
1dc8797 to
a4858c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47041590 |
|
This pull request was successfully merged by @philIip in c86f15a. When will my fix make it into a release? | Upcoming Releases |
|
Probably not safe to assume that all targets in the pbxproj are using React Native or connecting to a dev server. This change is modifying my widgets target to support loading. I also use widgets outside of my |
EvanBacon
reviewed
Dec 19, 2023
| info_plists = user_project | ||
| .files | ||
| .select { |p| | ||
| p.name&.end_with?('Info.plist') |
There was a problem hiding this comment.
Info.plist files should be discovered by tracing PBXProject > PBXNativeTarget > XCConfigurationList > XCBuildConfiguration > buildSettings.INFOPLIST_FILE.
EvanBacon
reviewed
Dec 19, 2023
|
|
||
| def self.update_ats_in_plist(plistPaths, parent) | ||
| plistPaths.each do |plistPath| | ||
| fullPlistPath = File.join(parent, plistPath.path) |
There was a problem hiding this comment.
This would only be accurate if you trace the join the paths of PBXFileReference.path | PBXFileReference.name with every parent PBXGroup.path according to sourceTree. Iirc cocoapods has some utility method for getting the real file path for a file.
EvanBacon
reviewed
Dec 19, 2023
| @@ -246,6 +246,7 @@ def react_native_post_install( | |||
| ReactNativePodsUtils.set_node_modules_user_settings(installer, react_native_path) | |||
| ReactNativePodsUtils.apply_flags_for_fabric(installer, fabric_enabled: fabric_enabled) | |||
| ReactNativePodsUtils.apply_xcode_15_patch(installer) | |||
| ReactNativePodsUtils.apply_ats_config(installer) | |||
There was a problem hiding this comment.
This should ultimately only be running on the target that the user added the function to, and not all targets in the pbxproj.
This was referenced Jan 11, 2024
3 tasks
gabrieldonadel
added a commit
to expo/expo
that referenced
this pull request
Jan 23, 2024
# Why On react-native 0.73 there was a change to the default template which automatically sets `NSAllowsArbitraryLoads` to false after running `pod install`. (facebook/react-native#38086) Temporary fix for #26573 # How As a temporary fix this PR updates the bare-minimum template to set a custom ATS configuration for `exp.direct` in order to allow users to use the `--tunnel` flag with expo cli. Until a proper fix is not implemented upstream, If users need to whitelist other HTTP domains they should manually add `NSExceptionDomains` to their `infoPlist` via app.json e.g. ```{ "expo": { "ios": { "infoPlist": { "CFBundleAllowMixedLocalizations": true, "NSAppTransportSecurity": { "NSExceptionDomains": { "your-custom-domain.test": { "NSIncludesSubdomains": true, "NSExceptionAllowsInsecureHTTPLoads": true } } } } } } } ``` # Test Plan ``` $ npx create-expo-app sdk50 $ cd sdk50 $ npx expo prebuild --template /path/to/expo/expo/expo-template-bare-minimum-*.tgz $ npx expo start --tunnel ``` # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
gabrieldonadel
added a commit
to expo/expo
that referenced
this pull request
Jan 23, 2024
On react-native 0.73 there was a change to the default template which automatically sets `NSAllowsArbitraryLoads` to false after running `pod install`. (facebook/react-native#38086) Temporary fix for #26573 As a temporary fix this PR updates the bare-minimum template to set a custom ATS configuration for `exp.direct` in order to allow users to use the `--tunnel` flag with expo cli. Until a proper fix is not implemented upstream, If users need to whitelist other HTTP domains they should manually add `NSExceptionDomains` to their `infoPlist` via app.json e.g. ```{ "expo": { "ios": { "infoPlist": { "CFBundleAllowMixedLocalizations": true, "NSAppTransportSecurity": { "NSExceptionDomains": { "your-custom-domain.test": { "NSIncludesSubdomains": true, "NSExceptionAllowsInsecureHTTPLoads": true } } } } } } } ``` ``` $ npx create-expo-app sdk50 $ cd sdk50 $ npx expo prebuild --template /path/to/expo/expo/expo-template-bare-minimum-*.tgz $ npx expo start --tunnel ``` <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
in this diff, we update the developer's Info.plists to have the correct ATS settings
introducing usage of products: https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project#products-instance_method, in order to retrieve the plists
Differential Revision: D47041590