Enable debugging in debug build #38205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47243235 |
Base commit: 5f84d73 |
Summary: Pull Request resolved: facebook#38205 Enable the preprocessor flag to allow debugging when in a debug build. This flag influences the Hermes headers included in the inspector, and causes them to include the debugging functionality. Changelog: [General][Fixed] - Re-enabled debugging for debug builds Reviewed By: lunaleaps, cortinico Differential Revision: D47243235 fbshipit-source-id: fcdc634922001781b644e4799e17be1f78461639
lunaleaps
force-pushed
the
export-D47243235
branch
from
f18ca7d to
21a41d2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47243235 |
|
This pull request was successfully merged by Matt Blagden in 41477c8. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Jul 10, 2023
Summary: Pull Request resolved: #38205 Enable the preprocessor flag to allow debugging when in a debug build. This flag influences the Hermes headers included in the inspector, and causes them to include the debugging functionality. Changelog: [General][Fixed] - Re-enabled debugging for debug builds Reviewed By: lunaleaps, cortinico Differential Revision: D47243235 fbshipit-source-id: 7982c69ab554335a9ad985394e4416ed69831137
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: facebook#38205 Enable the preprocessor flag to allow debugging when in a debug build. This flag influences the Hermes headers included in the inspector, and causes them to include the debugging functionality. Changelog: [General][Fixed] - Re-enabled debugging for debug builds Reviewed By: lunaleaps, cortinico Differential Revision: D47243235 fbshipit-source-id: 7982c69ab554335a9ad985394e4416ed69831137
This was referenced Aug 1, 2023
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enable the preprocessor flag to allow debugging when in a debug build. This flag influences the Hermes headers included in the inspector, and causes them to include the debugging functionality.
Changelog:
[General][Fixed] - Re-enabled debugging for debug builds
Differential Revision: D47243235