Skip to content

Bump Flipper to 0.201.0 #38260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

szymonrybczak
Copy link
Contributor

@szymonrybczak szymonrybczak commented Jul 9, 2023

Summary:

Bumped Flipper version from 0.182.0 to 0.201.0 (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see here for more context.

Changelog:

[General] [Changed] - Bump Flipper to 0.204.0

Test Plan:

CI Green ✅

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2023
@szymonrybczak szymonrybczak force-pushed the bump/flipper-version branch from fa30002 to fce1bba Compare July 9, 2023 11:19
@szymonrybczak
Copy link
Contributor Author

szymonrybczak commented Jul 9, 2023

Hm, looks like the artifacts for Android are not published. Same for iOS side, where the latest version published is 0.202.0, but the latest version released on is 0.204.0 ;(

@NickGerleman
Copy link
Contributor

I am seeing v0.201.0 available on Maven central for Android. Still a very recent build.

@NickGerleman
Copy link
Contributor

v0.196.0 and after also remove Flipper's Yoga dependency, which should let us clean up the iOS build quite a bit.

@cipolleschi
Copy link
Contributor

Cc. @cortinico: I don't think we can bump Flipper: IIRC, the new version of Flipper requires an NDK we do not support yet. And we don't want to have two different versions of Flipper for iOS and Android, right?

@szymonrybczak
Copy link
Contributor Author

I am seeing v0.201.0 available on Maven central for Android. Still a very recent build.

Yeah, but the flipper-fresco-plugin is still on 0.182.0.

@szymonrybczak
Copy link
Contributor Author

Cc. @cortinico: I don't think we can bump Flipper: IIRC, the new version of Flipper requires an NDK we do not support yet. And we don't want to have two different versions of Flipper for iOS and Android, right?

This bump is because we would like to bump NDK version in RN and it is necessarily to bump Flipper to version which contains NDK 25. See here for more context.

@cortinico
Copy link
Contributor

@szymonrybczak please use:
https://repo1.maven.org/maven2/com/facebook/flipper/flipper/0.201.0/

As for Fresco, we need to update to use this one instead:
https://repo1.maven.org/maven2/com/facebook/fresco/flipper-fresco-plugin/3.0.0/
(it depends on Flipper 0.183.+)

@szymonrybczak szymonrybczak force-pushed the bump/flipper-version branch from fce1bba to ca14543 Compare July 10, 2023 19:18
@analysis-bot
Copy link

analysis-bot commented Jul 10, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,831,836 +1
android hermes armeabi-v7a 8,140,637 +3
android hermes x86 9,336,254 +1
android hermes x86_64 9,178,908 +2
android jsc arm64-v8a 9,444,735 +3
android jsc armeabi-v7a 8,626,097 +2
android jsc x86 9,526,953 +2
android jsc x86_64 9,770,309 +1

Base commit: 0f85be8
Branch: main

@szymonrybczak
Copy link
Contributor Author

CI Green ✅

@NickGerleman I deleted the Yoga port from post_install and from tests, mind looking at this again? 🙏

@NickGerleman
Copy link
Contributor

CI Green ✅

@NickGerleman I deleted the Yoga port from post_install and from tests, mind looking at this again? 🙏

Thanks for doing this. There is some more cleanup we can do around Yoga headers, but that’s best for a separate change.

I will let @cortinico do a final review, but the YogaKit changes otherwise look good to me since we no longer pull in the dependency.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me @szymonrybczak thanks for doing this 👍
One thing, can I ask you to rebase on top of:

(It will land in the next hour or so).

We'd like to keep the bump of Fresco & Flipper isolated in separate commits.

@szymonrybczak szymonrybczak force-pushed the bump/flipper-version branch from ca14543 to f48f45a Compare July 11, 2023 13:29
@szymonrybczak szymonrybczak changed the title Bump Flipper to 0.204.0 Bump Flipper to 0.201.0 Jul 11, 2023
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 14, 2023
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in d9c8cd3.

@szymonrybczak szymonrybczak deleted the bump/flipper-version branch July 14, 2023 08:37
juniorklawa pushed a commit to juniorklawa/react-native that referenced this pull request Jul 20, 2023
Summary:
Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context.

## Changelog:

[General] [Changed] - Bump Flipper to 0.204.0

Pull Request resolved: facebook#38260

Test Plan: CI Green ✅

Reviewed By: NickGerleman, mdvacca

Differential Revision: D47373525

Pulled By: cortinico

fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
yayvery pushed a commit to discord/react-native that referenced this pull request Jan 11, 2024
Summary:
Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context.

[General] [Changed] - Bump Flipper to 0.204.0

Pull Request resolved: facebook#38260

Test Plan: CI Green ✅

Reviewed By: NickGerleman, mdvacca

Differential Revision: D47373525

Pulled By: cortinico

fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
yayvery pushed a commit to discord/react-native that referenced this pull request Jan 14, 2024
Summary:
Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context.

[General] [Changed] - Bump Flipper to 0.204.0

Pull Request resolved: facebook#38260

Test Plan: CI Green ✅

Reviewed By: NickGerleman, mdvacca

Differential Revision: D47373525

Pulled By: cortinico

fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
yayvery pushed a commit to discord/react-native that referenced this pull request Jan 14, 2024
Summary:
Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context.

[General] [Changed] - Bump Flipper to 0.204.0

Pull Request resolved: facebook#38260

Test Plan: CI Green ✅

Reviewed By: NickGerleman, mdvacca

Differential Revision: D47373525

Pulled By: cortinico

fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants