-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Bump Flipper to 0.201.0 #38260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Flipper to 0.201.0 #38260
Conversation
fa30002
to
fce1bba
Compare
Hm, looks like the artifacts for Android are not published. Same for iOS side, where the latest version published is |
I am seeing |
|
Cc. @cortinico: I don't think we can bump Flipper: IIRC, the new version of Flipper requires an NDK we do not support yet. And we don't want to have two different versions of Flipper for iOS and Android, right? |
Yeah, but the |
This bump is because we would like to bump NDK version in RN and it is necessarily to bump Flipper to version which contains NDK 25. See here for more context. |
@szymonrybczak please use: As for Fresco, we need to update to use this one instead: |
packages/react-native/ReactAndroid/flipper-integration/gradle.properties
Outdated
Show resolved
Hide resolved
fce1bba
to
ca14543
Compare
Base commit: 0f85be8 |
CI Green ✅ @NickGerleman I deleted the Yoga port from |
Thanks for doing this. There is some more cleanup we can do around Yoga headers, but that’s best for a separate change. I will let @cortinico do a final review, but the YogaKit changes otherwise look good to me since we no longer pull in the dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me @szymonrybczak thanks for doing this 👍
One thing, can I ask you to rebase on top of:
(It will land in the next hour or so).
We'd like to keep the bump of Fresco & Flipper isolated in separate commits.
ca14543
to
f48f45a
Compare
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cortinico merged this pull request in d9c8cd3. |
Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context. ## Changelog: [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: facebook#38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context. [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: facebook#38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context. [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: facebook#38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context. [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: facebook#38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c
Summary:
Bumped Flipper version from
0.182.0
to0.201.0
(which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see here for more context.Changelog:
[General] [Changed] - Bump Flipper to 0.204.0
Test Plan:
CI Green ✅